TUe/ZweedsPesten
2
0
Fork 0
Code Issues Pull requests Projects Releases 9 Packages Wiki Activity Actions

ui-tests #16

Merged
gulp1n merged 6 commits from ui-tests into ui 2025-10-21 13:42:15 +00:00
Conversation 3 Commits 6 Files changed 2 +24 -14
gulp1n commented 2025-10-21 13:04:07 +00:00
Owner
Copy link
No description provided.
tests work now
All checks were successful
pull request / build (pull_request) Successful in 29s
Details
pull request / test (pull_request) Successful in 20s
Details
3c130ba64a
Tiebe requested changes 2025-10-21 13:04:53 +00:00
Dismissed
Tiebe left a comment
Owner
Copy link

i hate it

i hate it
tests now edit hand instead of overriding hand check
All checks were successful
pull request / build (pull_request) Successful in 19s
Details
pull request / test (pull_request) Successful in 17s
Details
0cb3e53c12
Tiebe requested changes 2025-10-21 13:32:40 +00:00
Dismissed
src/test/java/nl/tue/game/GameManagerTest.java Outdated
@ -19,3 +21,3 @@
void setup() {
client = new LocalClient();
Client client2 = new LocalClient();
client2 = new LocalClient();
Tiebe commented 2025-10-21 13:30:55 +00:00
Owner
Copy link

Waarom is dit een class variable? Hij wordt toch nergens anders gebruikt?

Waarom is dit een class variable? Hij wordt toch nergens anders gebruikt?
gulp1n marked this conversation as resolved
src/test/java/nl/tue/game/GameManagerTest.java Outdated
@ -23,0 +26,4 @@
Deck deck = new Deck();
deck.initializeDeck();
sut.player1Hand.handCards = deck.getDeck();
Tiebe commented 2025-10-21 13:31:57 +00:00
Owner
Copy link

Op deze manier wordt de playCard niet meer goed getest. Daar wil je ook testen of ie checkt of je de kaart wel hebt

Op deze manier wordt de playCard niet meer goed getest. Daar wil je ook testen of ie checkt of je de kaart wel hebt
gulp1n marked this conversation as resolved
test now includes check for playerhand stuff
All checks were successful
pull request / build (pull_request) Successful in 22s
Details
pull request / test (pull_request) Successful in 20s
Details
2e2f504f7f
cleanup
All checks were successful
pull request / build (pull_request) Successful in 21s
Details
pull request / test (pull_request) Successful in 18s
Details
f388df4a9b
requested review from Tiebe 2025-10-21 13:37:56 +00:00
gulp1n self-assigned this 2025-10-21 13:38:49 +00:00
gulp1n changed title from WIP: ui-tests to ui-tests 2025-10-21 13:41:14 +00:00
Tiebe approved these changes 2025-10-21 13:41:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Tiebe
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
gulp1n
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TUe/ZweedsPesten#16
No description provided.
Delete branch "ui-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?