TUe/ZweedsPesten
2
0
Fork 0
Code Issues Pull requests Projects Releases 9 Packages Wiki Activity Actions

changed from 2 variables to a dict for clients, allowing for more players in the future. #17

Merged
gulp1n merged 4 commits from client-dict into ui 2025-10-22 09:29:36 +00:00
Conversation 3 Commits 4 Files changed 5 +121 -49
gulp1n commented 2025-10-21 16:43:48 +00:00
Owner
Copy link

and i was nice enough to write some javadoc

and i was nice enough to write some javadoc
cleanup + javadoc
All checks were successful
pull request / build (pull_request) Successful in 20s
Details
pull request / test (pull_request) Successful in 17s
Details
33c4b18459
Tiebe requested changes 2025-10-21 16:54:01 +00:00
Dismissed
src/main/java/nl/tue/game/GameManager.java
@ -30,2 +25,3 @@
public GameManager(Client client1, Client client2) {
public GameManager(List<Client> clientList) {
if (clientList.size() < 2) throw new IllegalArgumentException("you need at least 2 people to play");
Tiebe commented 2025-10-21 16:53:58 +00:00
Owner
Copy link

Ook even een check voor max spelers? Anders niet genoeg kaarten

Of meer kaarten in een deck gooien als er teveel spelers zijn

Ook even een check voor max spelers? Anders niet genoeg kaarten Of meer kaarten in een deck gooien als er teveel spelers zijn
gulp1n marked this conversation as resolved
added support for larger decks depending on player amount
All checks were successful
pull request / build (pull_request) Successful in 18s
Details
pull request / test (pull_request) Successful in 19s
Details
adeb9f96e4
requested review from Tiebe 2025-10-21 19:28:44 +00:00
gulp1n self-assigned this 2025-10-21 19:28:46 +00:00
Tiebe reviewed 2025-10-22 09:23:29 +00:00
src/main/java/nl/tue/game/GameManager.java Outdated
@ -35,3 +30,1 @@
this.client1 = client1;
this.client2 = client2;
deck.initializeDeck(clientList.size()/4 + 1);
Tiebe commented 2025-10-22 09:23:29 +00:00
Owner
Copy link

nit: vind eigenlijk dat dit even in een aparte variable met met een comment waarom /4+1

nit: vind eigenlijk dat dit even in een aparte variable met met een comment waarom /4+1
gulp1n commented 2025-10-22 09:24:39 +00:00
Author
Owner
Copy link

Zeik wijf

Zeik wijf
gulp1n marked this conversation as resolved
added variables for clarity
All checks were successful
pull request / build (pull_request) Successful in 27s
Details
pull request / test (pull_request) Successful in 20s
Details
ecc0eb34ef
Tiebe approved these changes 2025-10-22 09:29:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Tiebe
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
gulp1n
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TUe/ZweedsPesten#17
No description provided.
Delete branch "client-dict"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?