rules #11

Merged
Tiebe merged 18 commits from rules into main 2025-10-14 15:53:28 +00:00
Owner
No description provided.
Add joker test case
All checks were successful
build / build (pull_request) Successful in 21s
ba178a4e15
added islegal check w tests
All checks were successful
build / build (pull_request) Successful in 21s
aac2436397
added no daemon launch flag (#9)
Some checks failed
releaseNightly / build (push) Failing after 25s
e6280cb0cd
Reviewed-on: #9
Reviewed-by: Tiebe Groosman <tiebe@tiebe.me>
Co-authored-by: Gulp1n <abeldenouden@hotmail.com>
Co-committed-by: Gulp1n <abeldenouden@hotmail.com>
Add testing action
Some checks failed
releaseNightly / build (push) Failing after 24s
bf1ab58838
Implement navigation
All checks were successful
pull request / build (pull_request) Successful in 18s
pull request / test (pull_request) Successful in 18s
25214e5548
Merge pull request 'Implement navigation' (#12) from navigationHandler into main
Some checks failed
releaseNightly / build (push) Failing after 23s
8fe5c09b2d
Reviewed-on: #12
Reviewed-by: Abel den Ouden <abeldenouden@hotmail.com>
Merge branch 'rules' of ssh://git.tiebe.me/TUe/ZweedsPesten into rules
All checks were successful
pull request / build (pull_request) Successful in 19s
pull request / test (pull_request) Successful in 18s
10f2d595af
added more rules and expanded game manager and wrote more tests than i have sannity for
Some checks failed
pull request / build (pull_request) Failing after 12s
pull request / test (pull_request) Failing after 15s
d00afd4e06
gulp1n left a comment
Author
Owner

LGTM

LGTM
gulp1n self-assigned this 2025-10-14 15:16:01 +00:00
gulp1n changed title from WIP: rules to rules 2025-10-14 15:16:10 +00:00
Tiebe requested changes 2025-10-14 15:19:48 +00:00
Dismissed
@ -16,3 +16,1 @@
public Deck() {
initializeDeck();
}
// public Deck() {
Owner

remove commented code

remove commented code
gulp1n marked this conversation as resolved
@ -0,0 +7,4 @@
import java.util.ArrayList;
import java.util.List;
public class GameManager {
Owner

javadoc?

javadoc?
Tiebe marked this conversation as resolved
@ -0,0 +22,4 @@
deck.initializeDeck();
}
public void initializeGame() {
Owner

javadoc?

javadoc?
Tiebe marked this conversation as resolved
@ -0,0 +32,4 @@
initializePlayer(player2);
}
void initializePlayer(Player player) {
Owner

could be private

could be private
Tiebe marked this conversation as resolved
@ -0,0 +38,4 @@
player.setHandCards(deck.drawCards(3));
}
public void printState() {
Owner

remove empty function or implement it

remove empty function or implement it
Tiebe marked this conversation as resolved
@ -0,0 +101,4 @@
return true;
}
public boolean isSwappingAllowed() {
Owner

javadoc?

javadoc?
Tiebe marked this conversation as resolved
@ -0,0 +5,4 @@
import java.util.ArrayList;
import java.util.List;
public class LocalPlayer implements Player {
Owner

javadoc?

javadoc?
Tiebe marked this conversation as resolved
@ -0,0 +4,4 @@
import java.util.List;
public interface Player {
Owner

javadoc? same for each of the functions below

javadoc? same for each of the functions below
Tiebe marked this conversation as resolved
@ -0,0 +5,4 @@
import java.util.Arrays;
public class Rules {
Owner

javadoc

javadoc
gulp1n marked this conversation as resolved
@ -0,0 +26,4 @@
sut.playCard(player, new Card(Suit.CLUBS, Rank.FOUR));
}
var pile = sut.getPlayPile();
Owner

var?

var?
Author
Owner

yes, its short for variable

yes, its short for variable
gulp1n marked this conversation as resolved
Add javadocs
All checks were successful
pull request / build (pull_request) Successful in 18s
pull request / test (pull_request) Successful in 20s
0e2c171361
Update src/test/java/nl/tue/game/GameManagerTest.java
Some checks failed
pull request / build (pull_request) Failing after 16s
pull request / test (pull_request) Failing after 19s
ef55cd153e
resoved pr issues
Some checks failed
pull request / build (pull_request) Failing after 17s
pull request / test (pull_request) Failing after 17s
775ba3ba15
Update src/test/java/nl/tue/game/GameManagerTest.java
All checks were successful
pull request / build (pull_request) Successful in 18s
pull request / test (pull_request) Successful in 19s
9357245172
requested review from Tiebe 2025-10-14 15:50:38 +00:00
Tiebe approved these changes 2025-10-14 15:51:06 +00:00
Tiebe merged commit 2e0b47ea6d into main 2025-10-14 15:53:28 +00:00
Tiebe deleted branch rules 2025-10-14 15:53:33 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TUe/ZweedsPesten#11
No description provided.